Repository navigation
fix: duplicate history in mobile chrome - #61297
Conversation
|
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppa.mp4Android: mWeb Chromeaw.mp4iOS: HybridAppi.mp4iOS: mWeb Safariiw.mp4MacOS: Chrome / Safariw.mp4MacOS: Desktopd.mp4 |
|
@ahmedGaber93 I just added comment. Please help check. Thanks |
Co-authored-by: ahmedGaber93 <41129870+ahmedGaber93@users.noreply.github.com>
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
|
||
| onRouterClose(); | ||
| Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: updatedQuery})); | ||
| backHistory().then(() => { |
There was a problem hiding this comment.
Coming from this issue #62026, Adding the backHistory promise caused a slight delay on Android, so to resolve this, we've limited the promise to the web only, context: #62026 (comment)
|
This PR did not cause a regression, but it is worth noting for the pattern. It added the App/src/components/Modal/index.tsx Lines 23 to 28 in bc540c4 The fix was applied at the Search Router call sites instead of to the modal, so the ordering problem itself stayed in place. Over a year later, #92492 replaced the modal's history handling entirely. The helper became unnecessary and its extra The takeaway is that when the root cause sits in shared code, fixing it there avoids leaving a workaround that outlives the problem it solved. |
Explanation of Change
Fixed Issues
$ #58946
PROPOSAL: #58946 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-05-02.at.12.25.55.mov
Android: mWeb Chrome
output.mp4
iOS: Native
Screen.Recording.2025-05-02.at.12.34.16.mov
iOS: mWeb Safari
Screen.Recording.2025-05-02.at.12.32.13.mov
MacOS: Chrome / Safari
Screen.Recording.2025-05-02.at.12.21.39.mov
MacOS: Desktop
output.mp4